yahoo-eng-team team mailing list archive

[OpenStack Infra <1505414@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/398647
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3a3cb681c912863bca586f4354b9a0205f9b25f4
Submitter: Zuul
Branch:    master

commit 3a3cb681c912863bca586f4354b9a0205f9b25f4
Author: Ernest Millan <millan@xxxxxxxxx>
Date:   Wed Nov 16 16:00:17 2016 -0800

    Ensures proper network name in subnet error message
    
    We need to pass network object to _create_subnet()
    to show proper network name in subnet error message.
    The network itself has been retrieved in the view code, so what
    we need to do is to make it available in the workflow code.
    This commit makes 'network' information available in the workflow
    context_seed dict and CreateSubnet handle() method can use it.
    
    Also removes the unnecessary network_get in the admin subnet create
    form. we can retrieve a network object from context_seed['network']
    as we do in the project side code now.
    
    Change-Id: Ib2162814cbc7263fc03a9da0319c0b2b38732cc5
    Closes-bug: #1505414
    Co-Authored-By: Akihiro Motoki <amotoki@xxxxxxxxx>


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1505414

Title:
  Broken error message during subnet creation

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Whenever user create a Neutron subnet and Neutron returns error,
  Horizon will display :

  Error: Failed to create subnet "90.0.0.0/24" for network "None":
  <Neutron error message>

  Notice that "None" is supposed to be a network name.

  The root cause is due to
  horizon/horizon/openstack_dashboard/dashboards/project/networks/subnets/workflows.py
  never pass Network object in the _create_subnet method and that breaks
  the error message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1505414/+subscriptions