yahoo-eng-team team mailing list archive

[OpenStack Infra <1776481@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/575735
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=600ba8b8686d2c9ff48927f3af63ecbf53ef1847
Submitter: Zuul
Branch:    master

commit 600ba8b8686d2c9ff48927f3af63ecbf53ef1847
Author: Georg Hoesch <georg.hoesch@xxxxxxxx>
Date:   Fri Jun 15 14:52:35 2018 +0200

    refactor get_console_output() for console logfiles
    
    Refactor/simplify libvirt get_console_output() to allow integration
    of other console types from the hosts XML description
    
    completely restructure get_console_output():
    - make common code flow visible,
      including output and exceptions
    - simplify selection of console sources with one extensible struct
    - common checks for each error type (console not found/file not found)
    - extract pty-specific code
    
    functional changes:
    - none
    
    side effects:
    - Existence of pty-type consoles is now explicitly checked by the code and
      returns the same 'console logfile for instance does not exist' message
      as the  filebased console. Before, this case most likely triggered some
      obscure logmessage from readpty(). API-functionality is unchanged by
      this, both old and new code return an empty string.
    
    Closes-Bug: #1776481
    Change-Id: I3eac592f938a8d4ba813df535070e99b3130e863


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1776481

Title:
  WS-based serial port proxy prevents access to console log file

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  This bug occurs with interactive WS-based serial ports in nova. The serial
  console on the Websocket works fine, but configuring these consoles
  prevents access to the console logfile via 'openstack console log show'.
  This bug was discovered in pike with KVM-based virtualization but seems to
  be in current master as well.

  Access to the console logfile is very important because my websocket
  client is usually not permanently connected.

  Detailed analysis:
  The console logfile is still generated by KVM/libvirt. The only difference
  is that the path of the logfile node changed in the XML information for
  the instance. The relevant function get_console_output() in
  nova/virt/libvirt/driver.py fails to find the logfile (it just looks for
  @type='file', it should also look for @type='tcp').

  I'll try to provide a fix for this myself, it shouldn't be
  complicated.

  Any comments?

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1776481/+subscriptions