← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1809643] [NEW] Unit tests using fake_port1 and fake_port2 global variables are flaky

 

Public bug reported:

The unit test
test_enable_dhcp_helper_enable_metadata_nonisolated_dist_network
modifies the global variables fake_port1, fake_port2, creating flakiness
on unit tests that use those variables when execured in environments
with high concurrency.

How to reproduce:

Run unit tests on following patch
https://review.openstack.org/#/c/626641 with the following commands:

source .tox/py27/bin/activate
stestr run --concurrency=12 --until-failure neutron.tests.unit.agent.dhcp.test_agent.TestDhcpAgentEventHandler

After several iterations, the test port_create_end fails. Debugging the
failure you can see that the ports that fail are different than the
configured in the global variables, they have been modified by
test_enable_dhcp_helper_enable_metadata_nonisolated_dist_network

Reference: https://rbtcollins.wordpress.com/2015/12/02/diagnosing-flaky-
tests/

** Affects: neutron
     Importance: Undecided
     Assignee: Antonio Ojea (itsuugo)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1809643

Title:
  Unit tests using fake_port1 and fake_port2 global variables are flaky

Status in neutron:
  In Progress

Bug description:
  The unit test
  test_enable_dhcp_helper_enable_metadata_nonisolated_dist_network
  modifies the global variables fake_port1, fake_port2, creating
  flakiness on unit tests that use those variables when execured in
  environments with high concurrency.

  How to reproduce:

  Run unit tests on following patch
  https://review.openstack.org/#/c/626641 with the following commands:

  source .tox/py27/bin/activate
  stestr run --concurrency=12 --until-failure neutron.tests.unit.agent.dhcp.test_agent.TestDhcpAgentEventHandler

  After several iterations, the test port_create_end fails. Debugging
  the failure you can see that the ports that fail are different than
  the configured in the global variables, they have been modified by
  test_enable_dhcp_helper_enable_metadata_nonisolated_dist_network

  Reference: https://rbtcollins.wordpress.com/2015/12/02/diagnosing-
  flaky-tests/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1809643/+subscriptions


Follow ups