← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1806342] Re: Table header checkbox problem after searching on page

 

Reviewed:  https://review.openstack.org/621499
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=10ec5d517ebee4bffaf68874bbe383ee4a9d1d38
Submitter: Zuul
Branch:    master

commit 10ec5d517ebee4bffaf68874bbe383ee4a9d1d38
Author: Wangliangyu <wangliangyu@xxxxxxxxxxxxx>
Date:   Mon Dec 3 15:45:47 2018 +0800

    Update table header checkbox after searching
    
    Now, the table header checkbox has no releationship with
    the searching on page by javasricpt. This will cause two
    situations:
    - The table header checkbox is checked and delete button
      is enable when there is nothing under table.
    - The table header checkbox is not checked when all rows
      filtered out are checked.
    
    This commit will update the table header checkbox after
    searching on page side, and fix the above bug suitable.
    
    Change-Id: Ic290a67c7c85644bdedc80930c7d5be772fabde0
    Closes-Bug: #1806342


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1806342

Title:
  Table header checkbox problem  after searching on page

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  I found two problems about table header checkbox:

  Access Admin->Compute->Flavors.

  - 1.Search "m1" and check the table header checkbox, and now the all filtered out flavors are checked.
   2.Remove the search condition, and now the table header checkbox is also checked.

  - 1.Search "empty" and now there are nothing under the table.
   2.Check the table header checkbox, and now the delete button is enable.
   3.Click the delete button and there will throw an error prompt.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1806342/+subscriptions


References