yahoo-eng-team team mailing list archive

[OpenStack Infra <1809842@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/627430
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=372b75c2227e4cfba45ee02146275db2f30b87bd
Submitter: Zuul
Branch:    master

commit 372b75c2227e4cfba45ee02146275db2f30b87bd
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Thu Dec 27 09:51:15 2018 +0900

    Do not load openstack_dashboard.settings in unit tests
    
    The previous behavior depends on different values for
    SELECTABLE_THEMES and it seems this is the reason that test_themes
    imported openstack_dashboard.settings.
    If we override a value in django.conf.settings, we can use
    override_settings decorator. This commit uses it and
    we can now avoid importing openstack_dashboard.settings in UT.
    
    Change-Id: Id1b7b7e431b86e725ad897613ca38f423a67e52d
    Closes-Bug: #1809842


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1809842

Title:
  openstack_dashboard UT loads openstack_dashboard.settings

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In the openstack_dashboard unit tests, openstack_dashboard.settings is
  loaded unexpectedly. As side effect of this, files under
  openstack_dashboard/local are loaded and UT can fail if horizon
  plugins are configured.

  UT should depend on openstack_dashboard.test.settings only.
  This is caused by openstack_dashboard/test/unit/test_themes.py.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1809842/+subscriptions