yahoo-eng-team team mailing list archive

[OpenStack Infra <1812177@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/631179
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=975f0156137e37f7a9139c0268547d79dcc3c43c
Submitter: Zuul
Branch:    master

commit 975f0156137e37f7a9139c0268547d79dcc3c43c
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>
Date:   Wed Jan 16 10:57:07 2019 +0100

    Fix incompatible version handling in BuildRequest
    
    The BuildRequest object code assumed that IncompatibleObjectVersion
    exception has a objver field that contains the object version. This
    assumption is not true. The unit test made another mistake serializing
    the function object obj_to_primitive instead of serializing the result
    of the call of obj_to_primitive. This caused a false positive test
    covering the error in the implementation as well.
    
    Closes-Bug: #1812177
    
    Change-Id: I1ef4a23aa2bf5cb46b481045f3d968f62f74606d


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1812177

Title:
  BuildRequest ovo incorrectly assumes that IncompatibleObjectVersion
  exception has an objver field

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  BuildRequest ovo incorrectly assumes that IncompatibleObjectVersion
  exception has an objver field while handling such exception. This
  leads to an AttributeError during exception handling in [1].

  [1]
  https://github.com/openstack/nova/blob/e3b517b6fd7c470d5cee420fce1456b98495d310/nova/objects/build_request.py#L83

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1812177/+subscriptions