← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1813990] Re: Consistency Group Snapshot details links to wrong url

 

Reviewed:  https://review.openstack.org/634049
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=468184bd9754f41c072ee4afc54ca6f9a0de9af5
Submitter: Zuul
Branch:    master

commit 468184bd9754f41c072ee4afc54ca6f9a0de9af5
Author: jmoffitt <jeremy.moffitt@xxxxxxxx>
Date:   Wed Jan 30 13:26:22 2019 -0800

    Consistency Group Snapshots detail url is wrong
    
    The link in the consistency group table for "detail" is a mismatch
    for the corresponding value in the urls.py file, causing cg snapshots
    clicks to not load details for the user.
    
    This bug was introduced in https://review.openstack.org/#/c/429506
    where the link in tables.py was changed from:
    "horizon:project:volumes:cg_snapshots:cg_snapshot_detail"
    to
    "horizon:project:cg_snapshots:detail"
    
    the removal of the volumes section of the link was correct for that
    change, but changing "cg_snapshot_detail" to "detail" broke the
    details link
    
    Change-Id: I7ad8673bad353a234596df16c8e64eec93733934
    Closes-Bug: #1813990


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1813990

Title:
  Consistency Group Snapshot details links to wrong url

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Clicking the name of consistency group snapshot from
  Project->Volumes->Consistency Group Snapshots is supposed to take the
  user to the details panel for that snapshot, but the url is malformed.

  The name in:
  https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/cg_snapshots/urls.py#n21

  Does not match the link at:
  https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/cg_snapshots/tables.py#n93

  this bug was introduced in https://review.openstack.org/#/c/429506
  where the change to
  https://review.openstack.org/#/c/429506/13/openstack_dashboard/dashboards/project/cg_snapshots/tables.py
  changed "cg_snapshot_detail" to "detail" but did not make a
  corresponding change to the name in
  https://review.openstack.org/#/c/429506/13/openstack_dashboard/dashboards/project/cg_snapshots/urls.py

  As a result, users clicking on a Consistency Group Snapshot will not
  get details and will be asked if they want to open an xdg

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1813990/+subscriptions


References