yahoo-eng-team team mailing list archive

[OpenStack Infra <1812142@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/631386
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2bbd0e250917b9c7d65c067cb04d55fceccef7ae
Submitter: Zuul
Branch:    master

commit 2bbd0e250917b9c7d65c067cb04d55fceccef7ae
Author: Wangliangyu <wangliangyu@xxxxxxxxxxxxx>
Date:   Thu Jan 17 11:28:18 2019 +0800

    Ensure only one prompt for cidr and gateway_ip
    
    This commit makes 3 changes:
     - There should be only one prompt for field self. But required check
       in method clean checks the cleaned data, instead of the original value.
       So this commit set the fields required and remove the prompt when
       unnecessary.
     - According to below code [1], we know that initial equals context,
       and hidden with_subnet under subnet tab will conflict with
       the one under networks tab.
       So, this commit get with_subnet from initial, instead of cleaned_data.
     - Even with_subnet is False, the field checks are also valid and prevent
       the submitting. So, this commit remove erros for there fields.
    
    [1] https://github.com/openstack/horizon/blob/3730ec164e5a5d3d27ec46634910a0d8156984b6/horizon/workflows/base.py#L157
    
    Change-Id: I8fd14861c33e60cba90d4193ce8953a3b27bbe26
    Closes-Bug: #1812142


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1812142

Title:
  Gateway ip field throw more than one error when updating subnet

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  1.Access Project->Network->Networks page.
  2.Click one network with subnets and show it's subnets page.
  3.Edit one subnet and Fill an error gateway ip, like "10.0.0.".
  4.Click next,there will be two error prompts there, one on the top of the dialog, the other one is allocated the field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1812142/+subscriptions