yahoo-eng-team team mailing list archive

[OpenStack Infra <1814882@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/635170
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f651ebc0ceeca70aba8c0f7e5054f598e491c848
Submitter: Zuul
Branch:    master

commit f651ebc0ceeca70aba8c0f7e5054f598e491c848
Author: Stephen Finucane <sfinucan@xxxxxxxxxx>
Date:   Wed Feb 6 14:00:51 2019 +0000

    Don't set bandwidth limits for vhostuser, hostdev interfaces
    
    'tc' [1] is used for rate limiting in libvirt. This is suitable for tap
    devices but not for the sockets used by vhostuser interface or for
    physical devices; rate limiting for these interfaces must be done in the
    vSwitch or via the interface itself. For this reason, libvirt explicitly
    marks these interfaces, along with some other interfaces types, as not
    supporting bandwidth limiting [2]. Given that there is no reason to be
    setting the bandwidth-related attributes on vhostuser or hostdev
    interfaces, we should stop doing it.
    
    [1] http://man7.org/linux/man-pages/man8/tc.8.html
    [2] https://github.com/libvirt/libvirt/blob/568a41722/src/conf/netdev_bandwidth_conf.h#L38
    
    Change-Id: Id57e4c149616fe0896e80fca322ece79ec3bfd69
    Closes-Bug: #1814882


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1814882

Title:
  Bandwidth limits specified in flavors are not applied to generic vHost
  User interfaces

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Libvirt supports setting bandwidth limits for various VIF types.

  https://github.com/openstack/nova/blob/bcfd2439bab7cfad942d7e6a187df6edb1d1bf09/nova/virt/libvirt/vif.py#L576

  This is supported by pretty much all VIF types including vHost User
  interfaces defined by os-vif. However, generic vHost user interfaces
  do not set this field. This is a mistake and should be corrected.

  UPDATE: It appears the opposite is true. We're setting this for
  vhostuser interfaces but shouldn't be. See discussion starting at [1].

  [1] http://eavesdrop.openstack.org/irclogs/%23openstack-nova
  /%23openstack-nova.2019-02-06.log.html#t2019-02-06T16:28:10

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1814882/+subscriptions