yahoo-eng-team team mailing list archive

[OpenStack Infra <1815763@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/636627
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9cb825b0147af3b191ea2989e5187e4afdadcb15
Submitter: Zuul
Branch:    master

commit 9cb825b0147af3b191ea2989e5187e4afdadcb15
Author: Jim Rollenhagen <jim@xxxxxxxxxxxxxxxxxx>
Date:   Wed Feb 13 08:16:45 2019 -0500

    Ensure config regexes match the entire string
    
    Oslo.config uses re.search() to check config values against the allowed
    regex. This checks if the regex matches anywhere in the string, rather
    than checking if the entire string matches the regex.
    
    Make sure config options where the entire string should match the given
    regex actually do so.
    
    Change-Id: I9e30a24a4c0640f282f507d0a96640d3cdefe43c
    Closes-Bug: #1815763


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1815763

Title:
  Unbound regex in config options

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Oslo.config uses re.search() to check config values against the
  allowed regex. This checks if the regex matches anywhere in the
  string, rather than checking if the entire string matches the regex.

  Nova has three config options that appear as if the entire string should match the given regex:
  * DEFAULT.instance_usage_audit_period
  * cinder.catalog_info
  * serial_console.port_range

  However, these are not bounded with ^ and $ to ensure the entire
  string matches.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1815763/+subscriptions