yahoo-eng-team team mailing list archive

[OpenStack Infra <1815478@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/636174
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d8e8fe7db583d0a32b795c8be5ddfea1dc9ee97d
Submitter: Zuul
Branch:    master

commit d8e8fe7db583d0a32b795c8be5ddfea1dc9ee97d
Author: Andreas Karis <akaris@xxxxxxxxxx>
Date:   Mon Feb 11 12:04:20 2019 -0500

    Improve invalid port ranges error message
    
    Improve error message that is shown when
    port ranges are specified for protocols that don't
    support port ranges.
    
    Change-Id: I70ad9bd01f986efaed6682928cc5579c75bd4f6e
    Closes-Bug: #1815478
    Signed-off-by: Andreas Karis <akaris@xxxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1815478

Title:
  Error message 'Invalid protocol %(protocol)s for port range, only ...'
  is difficult to understand

Status in neutron:
  Fix Released

Bug description:
  Error message 'Invalid protocol %(protocol)s for port range, only ...' is difficult to understand.
  ~~~
   43 class SecurityGroupInvalidProtocolForPortRange(exceptions.InvalidInput):
   44     message = _("Invalid protocol %(protocol)s for port range, only "
   45                 "supported for TCP, UDP, UDPLITE, SCTP and DCCP.")
  ~~~

  Thinking about it logically, the port range is invalid for the
  protocol, not the other way around.

  The error message would be better as:
  ~~~
  Invalid port range specified for protocol %(protocol)s. Do not specify a port range. Port ranges are only supported for TCP, UDP, UDPLITE, SCTP and DCCP.
  ~~~

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1815478/+subscriptions