yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Public bug reported:

If we get here:

https://github.com/openstack/nova/blob/eb93d0cffd11fcfca97b3d4679a0043142a5d998/nova/objects/instance_mapping.py#L169

And the results are empty we can move on to the next cell without
querying the cell database since we have nothing to migrate.

Also, the joinedload on cell_mapping here:

https://github.com/openstack/nova/blob/eb93d0cffd11fcfca97b3d4679a0043142a5d998/nova/objects/instance_mapping.py#L164

Is not used so could also be removed.

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: In Progress

** Affects: nova/rocky
     Importance: Undecided
         Status: New


** Tags: db performance upgrade

** Also affects: nova/rocky
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1817961

Title:
  populate_queued_for_delete queries the cell database for instances
  even if there are no instance mappings to migrate in that cell

Status in OpenStack Compute (nova):
  In Progress
Status in OpenStack Compute (nova) rocky series:
  New

Bug description:
  If we get here:

  https://github.com/openstack/nova/blob/eb93d0cffd11fcfca97b3d4679a0043142a5d998/nova/objects/instance_mapping.py#L169

  And the results are empty we can move on to the next cell without
  querying the cell database since we have nothing to migrate.

  Also, the joinedload on cell_mapping here:

  https://github.com/openstack/nova/blob/eb93d0cffd11fcfca97b3d4679a0043142a5d998/nova/objects/instance_mapping.py#L164

  Is not used so could also be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1817961/+subscriptions