yahoo-eng-team team mailing list archive

[OpenStack Infra <1818560@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/640853
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=09090c8277284848007a8de1187b5cdc68c37d09
Submitter: Zuul
Branch:    master

commit 09090c8277284848007a8de1187b5cdc68c37d09
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Mon Mar 4 20:08:28 2019 +0000

    Use a placement conf when testing report client
    
    It turns out that the independent wsgi interceptors in
    test_report_client were using nova's global configuration
    when creating the intercepts using code from placement.
    This was working because until [1] placement's set of conf
    options had not diverged from nova's and nova still has
    placement_database config settings.
    
    This change takes advantage of new functionality in the
    PlacementFixture to allow the fixtur to manage config and
    database, but _not_ run the interceptor. This means it
    can set up a config that is later used by the independent
    interceptors that are used in the report client tests.
    
    [1] Ie43a69be8b75250d9deca6a911eda7b722ef8648
    
    Change-Id: I05326e0f917ca1b9a6ef8d3bd463f68bd00e217e
    Closes-Bug: #1818560
    Depends-On: I8c36f35dbe85b0c0db1a5b6b5389b160b68ca488


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1818560

Title:
  Nova test_report_client uses nova conf when starting placement
  intercept, causing missing config opts

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  See: http://logs.openstack.org/98/538498/22/gate/nova-tox-functional-
  py35/7673d3e/testr_results.html.gz

  The failing tests there are failing because the Database fixture from
  placement is used directly, and configuration opts are not being
  registered properly. This was an oversight when adding a new
  configuration setting.

  The fix is to register the missing opt when requested to do so.

  This is blocking the gate.

  LATER, to clarify:

  The root cause of this is that in test_report_client, a global CONF
  from nova was being used to create the placement wsgi-intercepts. When
  a new config was added on the placement side, that global CONF was no
  longer in sync.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1818560/+subscriptions