yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Public bug reported:

Because of this code in finish_revert_resize:

https://github.com/openstack/nova/blob/8cdb8cc7c56b574382b9a9fff662cc95e78136a2/nova/compute/manager.py#L4121

And the @errors_out_migration decorator on the method, if something
fails after that line we will save the migration object changes which
would leave the dest_compute pointing at the source_compute, which could
be very confusing when trying to debug.

The comment says the field is set temporarily but it's not really
temporary if the migration changes are saved like in that decorator.

** Affects: nova
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged


** Tags: compute resize

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
   Importance: Undecided => Medium

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1818730

Title:
  Errors in finish_revert_resize can leave migration.dest_compute
  pointing at source_compute

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  Because of this code in finish_revert_resize:

  https://github.com/openstack/nova/blob/8cdb8cc7c56b574382b9a9fff662cc95e78136a2/nova/compute/manager.py#L4121

  And the @errors_out_migration decorator on the method, if something
  fails after that line we will save the migration object changes which
  would leave the dest_compute pointing at the source_compute, which
  could be very confusing when trying to debug.

  The comment says the field is set temporarily but it's not really
  temporary if the migration changes are saved like in that decorator.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1818730/+subscriptions