← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1818765] [NEW] the PeriodicWorker function misssing the default desc in constructor

 

You have been subscribed to a public bug:


After this pr merged.https://review.openstack.org/#/c/637019/

we should add the default desc in PeriodicWorker. Otherwise some class

base on the PeriodicWorker which do not set the setproctitle off in
neutorn conf.

will get the core dump error. like below, where set_proctitle  is None
and do not

have the setproctitle config

packages/neutron/worker.py", line 21, in __init__
    set_proctitle = set_proctitle or cfg.CONF.setproctitle

    
ft2.2: tricircle.tests.unit.network.test_central_trunk_plugin.PluginTest.test_delete_trunk_StringException: Traceback (most recent call last):
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "tricircle/tests/unit/network/test_central_trunk_plugin.py", line 555, in test_delete_trunk
    fake_plugin.delete_trunk(q_ctx, t_trunk['id'])
  File "tricircle/network/central_trunk_plugin.py", line 70, in delete_trunk
    super(TricircleTrunkPlugin, self).delete_trunk(context, trunk_id)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/services/trunk/plugin.py", line 267, in delete_trunk
    if trunk_port_validator.can_be_trunked_or_untrunked(context):
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/services/trunk/rules.py", line 115, in can_be_trunked_or_untrunked
    if not self.is_bound(context):
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/services/trunk/rules.py", line 109, in is_bound
    core_plugin = directory.get_plugin()
  File "tricircle/tests/unit/network/test_central_trunk_plugin.py", line 254, in fake_get_plugin
    return FakeCorePlugin()
  File "tricircle/network/central_plugin.py", line 182, in __new__
    n = super(TricirclePlugin, cls).__new__(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py", line 106, in replacement_new
    instance = orig_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/db_base_plugin_v2.py", line 156, in __new__
    return super(NeutronDbPluginV2, cls).__new__(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py", line 126, in replacement_new
    instance = orig_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py", line 104, in replacement_new
    instance = super_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py", line 126, in replacement_new
    instance = orig_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py", line 106, in replacement_new
    instance = orig_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/external_net_db.py", line 77, in __new__
    return super(External_net_db_mixin, cls).__new__(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py", line 126, in replacement_new
    instance = orig_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/portbindings_db.py", line 54, in __new__
    return super(PortBindingMixin, cls).__new__(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py", line 124, in replacement_new
    instance = super_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py", line 124, in replacement_new
    instance = super_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py", line 106, in replacement_new
    instance = orig_new(cls, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/l3_db.py", line 96, in __new__
    inst._start_janitor()
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/l3_db.py", line 139, in _start_janitor
    initial_delay)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py", line 35, in __init__
    super(PeriodicWorker, self).__init__(worker_process_count=0)
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py", line 21, in __init__
    set_proctitle = set_proctitle or cfg.CONF.setproctitle
  File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2187, in __getattr__
    raise NoSuchOptError(name)
oslo_config.cfg.NoSuchOptError: no such option setproctitle in group [DEFAULT]

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
the PeriodicWorker function misssing the default desc in constructor
https://bugs.launchpad.net/bugs/1818765
You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron.


References