yahoo-eng-team team mailing list archive

[OpenStack Infra <1818639@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/641054
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6372a689e20252e4a18a59a6ded8841bfa5ed004
Submitter: Zuul
Branch:    master

commit 6372a689e20252e4a18a59a6ded8841bfa5ed004
Author: Radomir Dopieralski <openstack@xxxxxxxxxxxx>
Date:   Tue Mar 5 16:43:06 2019 +0100

    Don't use check_for_language in the user settings form
    
    That function is buggy and can't handle the Chinese language codes.
    
    Closes-Bug: #1818639
    Change-Id: I6ea03949f3ad6db82f5965de3fa028a84edf6cf3


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1818639

Title:
  Impossible to change language in user settings to Chinese

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  We use translation.check_for_language() function to validate the
  language code in our user settings form, however the way that function
  works bypasses the language code alias mechanisms, making it not work
  with the old zh_CN and zh_TW language codes, which have been replaced
  with zh_Hans and zh_Hant in Django. This is compounded with another
  bug in that function (https://code.djangoproject.com/ticket/28755),
  which made it work sometimes, if the process was started in the
  correct directory.

  We have several options for fixing it:
  1. Rename the Horizon translations for Chinese to match those of Django;
  2. Use absolute paths in LOCALE_PATHS or let Django generate those;
  3. Don't use check_for_language in the first place, as the field is already validated against the list of supported language codes from the settings.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1818639/+subscriptions