← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1819477] [NEW] [OVS] When cleaning min QoS, queue could be already deleted

 

Public bug reported:

When OVS agent is started and QoS extension is enabled, the minimum
bandwidth QoS and Queues are deleted [1]-->[2].

Although is not possible to have a QoS with deleted Queues assigned (a
"referential integrity violation" will be risen), a race condition could
happen during functional and fullstack tests [3].

While deleting the Queues referred in the Qos register, an exception
catch should be added to hide if the Queue is already deleted. In this
case there is no need to raise this exception.

[1] https://github.com/openstack/neutron/blob/590002728d4686cb947391911534c4d42f36cfb5/neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py#L57
[2] https://github.com/openstack/neutron/blob/590002728d4686cb947391911534c4d42f36cfb5/neutron/agent/common/ovs_lib.py#L992
[3] http://logs.openstack.org/95/642295/2/check/neutron-fullstack/26d552e/logs/dsvm-fullstack-logs/TestDscpMarkingQoSOvs.test_dscp_marking_packets_openflow-cli_/neutron-openvswitch-agent--2019-03-11--12-30-51-339462.txt.gz#_2019-03-11_12_30_57_450

** Affects: neutron
     Importance: Undecided
     Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Rodolfo Alonso (rodolfo-alonso-hernandez)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1819477

Title:
  [OVS] When cleaning min QoS, queue could be already deleted

Status in neutron:
  New

Bug description:
  When OVS agent is started and QoS extension is enabled, the minimum
  bandwidth QoS and Queues are deleted [1]-->[2].

  Although is not possible to have a QoS with deleted Queues assigned (a
  "referential integrity violation" will be risen), a race condition
  could happen during functional and fullstack tests [3].

  While deleting the Queues referred in the Qos register, an exception
  catch should be added to hide if the Queue is already deleted. In this
  case there is no need to raise this exception.

  [1] https://github.com/openstack/neutron/blob/590002728d4686cb947391911534c4d42f36cfb5/neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py#L57
  [2] https://github.com/openstack/neutron/blob/590002728d4686cb947391911534c4d42f36cfb5/neutron/agent/common/ovs_lib.py#L992
  [3] http://logs.openstack.org/95/642295/2/check/neutron-fullstack/26d552e/logs/dsvm-fullstack-logs/TestDscpMarkingQoSOvs.test_dscp_marking_packets_openflow-cli_/neutron-openvswitch-agent--2019-03-11--12-30-51-339462.txt.gz#_2019-03-11_12_30_57_450

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1819477/+subscriptions


Follow ups