yahoo-eng-team team mailing list archive

[OpenStack Infra <1816874@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/638331
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2ac0ee0b28c9c408aeb501d311c880afe59c4fb5
Submitter: Zuul
Branch:    master

commit 2ac0ee0b28c9c408aeb501d311c880afe59c4fb5
Author: Brian Haley <bhaley@xxxxxxxxxx>
Date:   Wed Feb 20 23:09:05 2019 -0500

    Fix pylint E1128 (assignment-from-no-return) in l3-agent
    
    Changed migrate_centralized_floating_ip() to return a
    status in DvrLocalRouter class.  Also changed the parent
    method in RouterInfo class to return FLOATINGIP_STATUS_NOCHANGE,
    which will cause the agent to not send an updated status for
    the floating IP.
    
    Also changed floating_ip_added_dist() to not use an
    intermediate variable and just return directly.
    
    Change-Id: I7dc4934308da95cf00a36b4ef1020aac7cef7d99
    Closes-bug: #1816874


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1816874

Title:
  l3 agent using return value from methods with no return

Status in neutron:
  Fix Released

Bug description:
  ************* Module neutron.agent.l3.dvr_local_router
  neutron/agent/l3/dvr_local_router.py:111:12: E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return)
  ************* Module neutron.agent.l3.router_info
  neutron/agent/l3/router_info.py:380:16: E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return)

  Note that the lines in those two files about pylint disable
  assignment-from-no-return, if still there, should be removed when this
  is fixed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1816874/+subscriptions