yahoo-eng-team team mailing list archive

[LIU Yulong <yulong@xxxxxxxxxxxxx>]

Neutron just merged this BP recently:
https://review.openstack.org/#/q/status:merged+branch:master+topic:bp/network-segment-range-management
Please following the new required params to refactor the code, maybe these lines in tricircle itself:
https://github.com/openstack/tricircle/blob/master/tricircle/network/drivers/type_vlan.py#L53
https://github.com/openstack/tricircle/blob/master/tricircle/network/drivers/type_vxlan.py#L52

** Changed in: neutron
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1820174

Title:
  create network failed as allocate_tenant_segment function break out
  TypeError

Status in neutron:
  Invalid
Status in Tricircle:
  New

Bug description:
  when runnning tricircle testcase
  TypeError was breaked out when create netowrk as follows:
  2019-03-11 16:20:46.679438 | ubuntu-xenial | {3} tricircle.tests.unit.network.test_central_plugin.PluginTest.test_delete_local_router [0.259334s] ... FAILED
  2019-03-11 16:20:46.679531 | ubuntu-xenial |
  2019-03-11 16:20:46.679675 | ubuntu-xenial | Captured traceback:
  2019-03-11 16:20:46.679858 | ubuntu-xenial | ~~~~~~~~~~~~~~~~~~~
  2019-03-11 16:20:46.680116 | ubuntu-xenial |     Traceback (most recent call last):
  2019-03-11 16:20:46.680737 | ubuntu-xenial |       File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
  2019-03-11 16:20:46.680941 | ubuntu-xenial |         return func(*args, **keywargs)
  2019-03-11 16:20:46.681347 | ubuntu-xenial |       File "tricircle/tests/unit/network/test_central_plugin.py", line 3465, in test_delete_local_router
  2019-03-11 16:20:46.681701 | ubuntu-xenial |         t_ctx, q_ctx, fake_plugin, '["pod_1"]', ["pod_1"], '["pod_1"]')
  2019-03-11 16:20:46.682279 | ubuntu-xenial |       File "tricircle/tests/unit/network/test_central_plugin.py", line 3090, in _prepare_associate_floatingip_test
  2019-03-11 16:20:46.682600 | ubuntu-xenial |         e_net = fake_plugin.create_network(q_ctx, {'network': net_body})
  2019-03-11 16:20:46.682995 | ubuntu-xenial |       File "tricircle/tests/unit/network/test_central_plugin.py", line 825, in create_network
  2019-03-11 16:20:46.683289 | ubuntu-xenial |         net = super(FakePlugin, self).create_network(context, network)
  2019-03-11 16:20:46.683604 | ubuntu-xenial |       File "tricircle/network/central_plugin.py", line 319, in create_network
  2019-03-11 16:20:46.683721 | ubuntu-xenial |         tenant_id)
  2019-03-11 16:20:46.684041 | ubuntu-xenial |       File "tricircle/network/managers.py", line 76, in create_network_segments
  2019-03-11 16:20:46.684298 | ubuntu-xenial |         segment = self._allocate_tenant_net_segment(context)
  2019-03-11 16:20:46.684959 | ubuntu-xenial |       File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/plugins/ml2/managers.py", line 282, in _allocate_tenant_net_segment
  2019-03-11 16:20:46.685257 | ubuntu-xenial |         segment = self._allocate_segment(context, network_type, filters)
  2019-03-11 16:20:46.685942 | ubuntu-xenial |       File "/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/plugins/ml2/managers.py", line 276, in _allocate_segment
  2019-03-11 16:20:46.686259 | ubuntu-xenial |         return driver.obj.allocate_tenant_segment(context.session, filters)
  2019-03-11 16:20:46.686573 | ubuntu-xenial |     TypeError: allocate_tenant_segment() takes exactly 2 arguments (3 given)
  2019-03-11 16:20:46.686643 | ubuntu-xenial |
  2019-03-11 16:20:46.687094 | ubuntu-xenial | {7} tricircle.tests.unit.common.test_exception.TricircleExceptionTestCase.test_error_code_from_kwarg [0.000366s] ... ok

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1820174/+subscriptions