← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1819029] Re: QoS policies with minimum-bandwidth rule should be rejected on non-physnet ports/networks

 

Reviewed:  https://review.openstack.org/641712
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d1696619c5636bc74d5238520db80b01cb81921d
Submitter: Zuul
Branch:    master

commit d1696619c5636bc74d5238520db80b01cb81921d
Author: Bence Romsics <bence.romsics@xxxxxxxxxxxx>
Date:   Thu Mar 7 10:07:12 2019 +0100

    Reject min-bw rule operations on non-physnet networks/ports
    
    Change-Id: I54d421d0993bd9515ab5ba32f75f40d1ef46eccb
    Closes-Bug: #1819029
    Depends-On: https://review.openstack.org/644847


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1819029

Title:
  QoS policies with minimum-bandwidth rule should be rejected on non-
  physnet ports/networks

Status in neutron:
  Fix Released

Bug description:
  We seem to have forgot to reject some API operations that are actually
  not supported (and weren't planned to be supported) by the Stein
  implementation of the Guaranteed Minimum Bandwidth feature.

  That is QoS policies with a minimum-bandwidth rule should not be used
  on ports/networks that are not backed by a physnet. But currently we
  allow this:

  $ openstack network show private | egrep provider
  | provider:network_type     | vxlan
  | provider:physical_network | None
  | provider:segmentation_id  | 1062

  $ openstack network qos policy create policy0
  $ openstack network qos rule create policy0 --type minimum-bandwidth --min-kbps 1000 --egress
  $ openstack port create port0 --network private --qos-policy policy0

  The port-create seems to work today, but on non-physnet networks
  there's no guarantee at all (as planned in the blueprint). Therefore I
  think API operations like these should be rejected now, otherwise we
  may set up false expectations in our users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1819029/+subscriptions


References