yahoo-eng-team team mailing list archive

[Mohammed Naser <1822676@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

For a long time, noVNC set the token inside a cookie so that when the
/websockify request came in, we had it in the cookies and we could look
it up from there and return the correct host.

However, since the following commit, they've removed this behavior

https://github.com/novnc/noVNC/commit/51f9f0098d306bbc67cc8e02ae547921b6f6585c
#diff-1d6838e3812778e95699b90d530543a1L173

This means that we're unable to use latest noVNC with Nova.  There is a
really gross workaround of using the 'path' override in the URL for
something like this

http://foo/vnc_lite.html?path=?token=foo

That feels pretty lame to me and it will have all deployment tools
change their settings.  Also, this wasn't caught in CI because we deploy
novnc from packages.

** Affects: nova
     Importance: High
     Assignee: melanie witt (melwitt)
         Status: Confirmed

** Affects: openstack-ansible
     Importance: Undecided
         Status: New


** Tags: console

** Also affects: openstack-ansible
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1822676

Title:
  novnc no longer sets token inside cookie

Status in OpenStack Compute (nova):
  Confirmed
Status in openstack-ansible:
  New

Bug description:
  For a long time, noVNC set the token inside a cookie so that when the
  /websockify request came in, we had it in the cookies and we could
  look it up from there and return the correct host.

  However, since the following commit, they've removed this behavior

  https://github.com/novnc/noVNC/commit/51f9f0098d306bbc67cc8e02ae547921b6f6585c
  #diff-1d6838e3812778e95699b90d530543a1L173

  This means that we're unable to use latest noVNC with Nova.  There is
  a really gross workaround of using the 'path' override in the URL for
  something like this

  http://foo/vnc_lite.html?path=?token=foo

  That feels pretty lame to me and it will have all deployment tools
  change their settings.  Also, this wasn't caught in CI because we
  deploy novnc from packages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1822676/+subscriptions