yahoo-eng-team team mailing list archive

[OpenStack Infra <1822355@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/648748
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2623acaba4573738faa61658af2d6006da6918a0
Submitter: Zuul
Branch:    master

commit 2623acaba4573738faa61658af2d6006da6918a0
Author: Stephen Finucane <sfinucan@xxxxxxxxxx>
Date:   Fri Mar 29 17:45:46 2019 +0000

    tests: Full stub out os_vif
    
    os_vif does some stuff that requires privsep and shouldn't happen.
    We had already stubbed out the 'plug' operation but missed the 'unplug'
    one, resulting in an ugly warning in the logs. Fix the stubbing to avoid
    these calls.
    
    Change-Id: Id181f5fa5b8edb92fdcad2ce777bafb9e3d60b5e
    Closes-Bug: #1822355


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1822355

Title:
  Incomplete stubbing of os-vif in libvirt functional tests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  If a functional test fails, we see the following in the logs:

      2019-03-29 17:37:10,856 INFO [nova.compute.manager] Terminating instance                                                                                                                                       
      2019-03-29 17:37:10,859 INFO [nova.api.openstack.requestlog] 127.0.0.1 "GET /v2/6f70656e737461636b20342065766572/servers/detail" status: 200 len: 1569 microversion: 2.1 time: 0.289134                        
      2019-03-29 17:37:10,867 INFO [nova.virt.libvirt.driver] Instance destroyed successfully.                                                                                                                       
      2019-03-29 17:37:10,869 ERROR [vif_plug_ovs.ovsdb.impl_vsctl] Unable to execute ['ovs-vsctl', '--timeout=120', '--oneline', '--format=json', '--db=tcp:127.0.0.1:6640', '--', '--if-exists', 'del-port', u'br-i
  nt', u'tap88dae9fa-0d']. Exception: You have attempted to start a privsep helper. This is not allowed in the gate, and indicates a failure to have mocked your tests.                                             
      2019-03-29 17:37:10,870 ERROR [os_vif] Failed to unplug vif VIFOpenVSwitch(active=True,address=00:0c:29:0d:11:74,bridge_name='br-int',has_traffic_filtering=False,id=88dae9fa-0dc6-49e3-8c29-3abc41e99ac9,netwo
  rk=Network(3cb9bc59-5699-4588-a4b1-b87f96708bc6),plugin='ovs',port_profile=VIFPortProfileOpenVSwitch,preserve_on_delete=False,vif_name='tap88dae9fa-0d')                                                           
      Traceback (most recent call last):                                                                                                                                                                             
        File "/home/sfinucan/Development/openstack/nova/.tox/functional/lib/python2.7/site-packages/os_vif/__init__.py", line 110, in unplug                                                                         
          plugin.unplug(vif, instance_info)                                                                                                                                                                       
        File "/home/sfinucan/Development/openstack/nova/.tox/functional/lib/python2.7/site-packages/vif_plug_ovs/ovs.py", line 344, in unplug                                              
          self._unplug_vif_generic(vif, instance_info)                                                                                                                                                               
        File "/home/sfinucan/Development/openstack/nova/.tox/functional/lib/python2.7/site-packages/vif_plug_ovs/ovs.py", line 318, in _unplug_vif_generic                 
          self.ovsdb.delete_ovs_vif_port(vif.network.bridge, vif.vif_name)                                                                                                  
        File "/home/sfinucan/Development/openstack/nova/.tox/functional/lib/python2.7/site-packages/vif_plug_ovs/ovsdb/ovsdb_lib.py", line 90, in delete_ovs_vif_port                                                
          linux_net.delete_net_dev(dev)                                                                                                                                                                              
        File "/home/sfinucan/Development/openstack/nova/.tox/functional/lib/python2.7/site-packages/oslo_privsep/priv_context.py", line 240, in _wrap                                                                
          self.start()                                                                                                                                                                                               
        File "/home/sfinucan/Development/openstack/nova/.tox/functional/lib/python2.7/site-packages/oslo_privsep/priv_context.py", line 251, in start                                                                
          channel = daemon.RootwrapClientChannel(context=self)                                                                                                                                                      
        File "nova/tests/fixtures.py", line 2018, in __init__                                                                                                                                                        
          raise Exception('You have attempted to start a privsep helper. '                                                                                                                                           
      Exception: You have attempted to start a privsep helper. This is not allowed in the gate, and indicates a failure to have mocked your tests.

  As that suggests, we have a problem we should rectify.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1822355/+subscriptions