yahoo-eng-team team mailing list archive

[OpenStack Infra <1821824@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/648653
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c088856c8c08f0ab0746db7c120da494c9dd42d4
Submitter: Zuul
Branch:    master

commit c088856c8c08f0ab0746db7c120da494c9dd42d4
Author: mb <mb@xxxxxxxxxxxxxx>
Date:   Fri Mar 29 10:20:58 2019 +0100

    Fix bug preventing forbidden traits from working
    
    Modifies _clean_empties function to take forbidden traits into account
    in addition to required traits.
    
    Added unit test test_resources_from_request_spec_flavor_forbidden_trait
    to test that a single forbidden trait doesn't get lost in the
    resources_from_request_spec function.
    
    Also updated the functional test
    test_flavor_forbidden_traits_based_scheduling to do the right thing.
    
    Change-Id: I491b10c9c202baae4a37034848147f910a50eebf
    Closes-Bug: #1821824


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1821824

Title:
  Forbidden traits in flavor properties don't work

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) rocky series:
  Confirmed
Status in OpenStack Compute (nova) stein series:
  Confirmed

Bug description:
  Due to an error when implementing forbidden traits they are stripped
  off in the _clean_empties function in nova/scheduler/utils.py which
  only takes required_traits into account.

  This means that forbidden traits won't be acted upon and an instance
  started with a flavor with a forbidden trait still can end up on a
  resource provider with that trait set.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1821824/+subscriptions