yahoo-eng-team team mailing list archive

[OpenStack Infra <1823059@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/649681
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a39bc9758cc713d46092101475ac4edd404f93f5
Submitter: Zuul
Branch:    master

commit a39bc9758cc713d46092101475ac4edd404f93f5
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Apr 3 18:48:32 2019 +0100

    Join on explcit relationship paths
    
    The join() in get_router_for_floatingip() is joining from entity
    to entity without an explicit ON clause which creates an ambiguous
    situation. SQLAlchemy 1.3 guards against this now, so use the
    real relationship-bound path so that the ORM does not need to guess.
    
    This mock replicates the original query without the
    "gw_port.device_owner == DEVICE_OWNER_ROUTER_GW" filter.
    
    Error [1] found in [2].
    
    Based on [3].
    
    [1] http://paste.openstack.org/show/748825
    [2] https://review.openstack.org/#/c/649508
    [3] https://review.openstack.org/#/c/642117
    
    Change-Id: I7e12e2a2b6f9e8eb2233819f41d1065c95f0d552
    Closes-Bug: #1823059


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1823059

Title:
  Specify FROM clause to join from in
  test_floatingip_via_router_interface_returns_201

Status in neutron:
  Fix Released

Bug description:
  With SQLAlchemy===1.3.2 [1], in test case "test_floatingip_via_router_interface_returns_201", we need to specify which FROM clause to join from, when multiple FROMS are present [2]. In this case:
      models_v2.Port.id == models_v2.IPAllocation.port_id

  [1] https://review.openstack.org/#/c/649508
  [2] http://paste.openstack.org/show/748825/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1823059/+subscriptions