← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1819160] Re: Functional tests for dvr ha routers are broken

 

Reviewed:  https://review.openstack.org/647784
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8cc480bd01d21f05296c77db231b706a7dc5b475
Submitter: Zuul
Branch:    master

commit 8cc480bd01d21f05296c77db231b706a7dc5b475
Author: LIU Yulong <i@xxxxxxxxxxxx>
Date:   Tue Mar 26 23:47:11 2019 +0800

    Set HA failover bridges veth pair devices UP
    
    The test bridge veth pair devices is not up which cause the
    VRRP advertisement packet can not pass to each HA port. Then
    multiple master router is up. This patch just sets the veth
    pair devices up.
    
    Closes-Bug: #1819160
    Change-Id: I0e0d0311d73bce83d3c7341e7a0167917818b1ff


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1819160

Title:
  Functional tests for dvr ha routers are broken

Status in neutron:
  Fix Released

Bug description:
  As a result of debugging issues reported in
  https://bugs.launchpad.net/neutron/+bug/1818614 I found an issue with
  functional tests:

  test_dvr_ha_router_failover_with_gw,
  test_dvr_ha_router_failover_without_gw,
  test_dvr_ha_router_failover_with_gw_and_floatingip

  from module neutron.tests.functional.agent.l3.test_dvr_router are
  broken.

  
  First thing which is wrong there is fact that those tests creates 2 independent routers on 2 agents. It's not one router in "master" and "standby" mode. Please check in https://github.com/openstack/neutron/blob/68fd13af40ce2752d2919ca569d3d3fe00ff6444/neutron/tests/functional/agent/l3/test_dvr_router.py#L1503

  Second issue is that it assumes that always router on agent1 will be
  "master" and that may be different sometimes as it depends on
  keepalived negotiations.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1819160/+subscriptions


References