yahoo-eng-team team mailing list archive

[OpenStack Infra <1818798@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/641282
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=24fe74d126f23bea56c87524b1005a2aaacb870c
Submitter: Zuul
Branch:    master

commit 24fe74d126f23bea56c87524b1005a2aaacb870c
Author: Kevin_Zheng <zhengzhenyu@xxxxxxxxxx>
Date:   Wed Mar 6 16:48:10 2019 +0800

    Should not skip volume_size check for bdm.image_id == image_ref case
    
    The volume size should be checked in bdm.sourece_type=image,
    dest_type=volume case no matter what the image
    is, but we skipped the check if the bdm.image_id == image_ref,
    we should not skipped the volume_size check.
    
    Change-Id: Ib10579280b63a4dd59ac76733aa0ff48fd2e024b
    closes-bug: 1818798


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1818798

Title:
  Should not skip volume_size check for bdm.image_id == image_ref case

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The volume size should be checked in bdm.sourece_type=image, dest_type=volume case no matter what the image
  is, but in:
  https://github.com/openstack/nova/blob/5a09c81af3b438ecbcf27fa653095ff55abb3ed4/nova/compute/api.py#L1452-L1453
  we skipped the check if the bdm.image_id == image_ref, it was meant to skip only the _get_image() check as it
  is already checked before, but it skipped the volume_size check too.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1818798/+subscriptions