← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1824017] [NEW] stein requires python-cinderclient >= 4.0.0

 

Public bug reported:

Attempting to create volume from stein dashboard fails with "Error:
Unable to create volume.".

The log shows:
[Tue Apr 09 17:40:58.263170 2019] [wsgi:error] [pid 18815:tid 140441351403264] [remote 10.5.0.17:50962] Recoverable error: Invalid input for field/attribute volume. Value: {'size': 1,
'consistencygroup_id': None, 'snapshot_id': None, 'name': 'b1', 'description': '', 'volume_type': '', 'user_id': None, 'project_id': None, 'availability_zone': 'nova', 'status': 'creating', 'attach_status': 'detached', 'metadata': {}, 'imageRef': None, 'source_volid': None, 'source_replica': None, 'multiattach': False, 'backup_id': None}. Additional properties are not allowed ('project_id', 'user_id', 'status', 'attach_status', 'source_replica' were unexpected) (HTTP 400) (Request-ID: req-e64a3589-403c-4c58-87dd-58233a70bde6)                    

We're running with python3-cinderclient 1:3.5.0-0ubuntu1. Upgrading to
python3-cinderclient 1:4.1.0-0ubuntu1 fixes this.

Relevent python-cinderclient commit from version 4.0.0:

commit 8d566689001a442c2312e366acc167af88888fd3
Author: Neha Alhat <neha.alhat@xxxxxxxxxxx>
Date:   Thu Jun 7 18:22:16 2018 +0530

    Remove unnecessary parameters from volume create APIs
    
    As per Cinder code, following parameters are not required to be
    passed in the request body of create volume API.
    
        * status
        * user_id
        * attach_status
        * project_id
        * source_replica
    
    If you pass these parameters, previously it was ignored but in the
    schema validation changes[1] we don't allow additionalProperties to be
    passed in the request body. If user passes additional parameters which
    are not as per API specs[2], then it will be rejected with 400 error.
    On patch[3], tempest tests: test_volume_snapshot_create_get_list_delete,
    test_volume_create_get_delete" are failing because of these unnecessary
    parameters.
    
    This patch removes these unnecessary parameters passed to the create
    Volume API.
    
    [1]https://blueprints.launchpad.net/cinder/+spec/json-schema-validation
    [2]https://review.openstack.org/#/c/507386/
    [3]https://review.openstack.org/#/c/573093/
    
    Change-Id: I37744bfd0b0bc59682c3e680c1200f608ad3991b

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1824017

Title:
  stein requires python-cinderclient >= 4.0.0

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Attempting to create volume from stein dashboard fails with "Error:
  Unable to create volume.".

  The log shows:
  [Tue Apr 09 17:40:58.263170 2019] [wsgi:error] [pid 18815:tid 140441351403264] [remote 10.5.0.17:50962] Recoverable error: Invalid input for field/attribute volume. Value: {'size': 1,
  'consistencygroup_id': None, 'snapshot_id': None, 'name': 'b1', 'description': '', 'volume_type': '', 'user_id': None, 'project_id': None, 'availability_zone': 'nova', 'status': 'creating', 'attach_status': 'detached', 'metadata': {}, 'imageRef': None, 'source_volid': None, 'source_replica': None, 'multiattach': False, 'backup_id': None}. Additional properties are not allowed ('project_id', 'user_id', 'status', 'attach_status', 'source_replica' were unexpected) (HTTP 400) (Request-ID: req-e64a3589-403c-4c58-87dd-58233a70bde6)                    

  We're running with python3-cinderclient 1:3.5.0-0ubuntu1. Upgrading to
  python3-cinderclient 1:4.1.0-0ubuntu1 fixes this.

  Relevent python-cinderclient commit from version 4.0.0:

  commit 8d566689001a442c2312e366acc167af88888fd3
  Author: Neha Alhat <neha.alhat@xxxxxxxxxxx>
  Date:   Thu Jun 7 18:22:16 2018 +0530

      Remove unnecessary parameters from volume create APIs
      
      As per Cinder code, following parameters are not required to be
      passed in the request body of create volume API.
      
          * status
          * user_id
          * attach_status
          * project_id
          * source_replica
      
      If you pass these parameters, previously it was ignored but in the
      schema validation changes[1] we don't allow additionalProperties to be
      passed in the request body. If user passes additional parameters which
      are not as per API specs[2], then it will be rejected with 400 error.
      On patch[3], tempest tests: test_volume_snapshot_create_get_list_delete,
      test_volume_create_get_delete" are failing because of these unnecessary
      parameters.
      
      This patch removes these unnecessary parameters passed to the create
      Volume API.
      
      [1]https://blueprints.launchpad.net/cinder/+spec/json-schema-validation
      [2]https://review.openstack.org/#/c/507386/
      [3]https://review.openstack.org/#/c/573093/
      
      Change-Id: I37744bfd0b0bc59682c3e680c1200f608ad3991b

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1824017/+subscriptions


Follow ups