← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1824138] Re: Fullstack QoS tests should not handle other tests port events

 

Reviewed:  https://review.openstack.org/651523
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1c1f17688216f221abbcb6b2f598d0f5c0e1a877
Submitter: Zuul
Branch:    master

commit 1c1f17688216f221abbcb6b2f598d0f5c0e1a877
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Thu Apr 11 09:37:46 2019 +0000

    Avoid fullstack QoS tests to handle other test ports
    
    In order to isolate the concurrent execution of fullstack QoS tests,
    the function QosAgentExtension._process_reset_port() is mocked to
    avoid any port reset created by other test.
    
    Change-Id: Ib78098387e90b6c315d3e969004f5786ace8696e
    Closes-Bug: #1824138


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1824138

Title:
  Fullstack QoS tests should not handle other tests port events

Status in neutron:
  Fix Released

Bug description:
  In [1], a test should not handle other tests port events. For example,
  in [2], the test is processing the port 76a94041-47d1-4709-a78a-
  a6562aa5b2e3, which was created at the same time by [3].

  In order to solve this concurrency problem, a solution could be to
  mock the QoS extension function to reset a port [4].

  The solution for this bug should be backported to Stein (Rocky doesn't
  have this problem).

  
  [1] https://github.com/openstack/neutron/blob/master/neutron/tests/fullstack/test_qos.py
  [2] http://logs.openstack.org/85/644385/9/gate/neutron-fullstack/f7d4eb4/controller/logs/dsvm-fullstack-logs/TestMinBwQoSOvs.test_min_bw_qos_policy_rule_lifecycle_egress,openflow-native_/neutron-openvswitch-agent--2019-04-09--12-35-31-673671_log.txt.gz#_2019-04-09_12_35_46_545
  [3] http://logs.openstack.org/85/644385/9/gate/neutron-fullstack/f7d4eb4/controller/logs/dsvm-fullstack-logs/TestMinBwQoSOvs.test_bw_limit_qos_port_removed_egress,openflow-native_/neutron-openvswitch-agent--2019-04-09--12-35-30-421527_log.txt.gz#_2019-04-09_12_35_43_544
  [4] https://github.com/openstack/neutron/blob/master/neutron/agent/l2/extensions/qos.py#L297

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1824138/+subscriptions


References