yahoo-eng-team team mailing list archive

[OpenStack Infra <1825291@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/653898
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=2bea568b4cd4968dcbe64f55247a970545e911af
Submitter: Zuul
Branch:    master

commit 2bea568b4cd4968dcbe64f55247a970545e911af
Author: Dongcan Ye <hellochosen@xxxxxxxxx>
Date:   Fri Apr 19 02:24:31 2019 +0000

    Fix vpn agent delete router error
    
    Since commit 4bb78e8c215d24cd2fc9168e7bfbb47ceb89de3e pass a dict
    for router_info instead of router_id, we need to changes in
    our repo.
    
    Change-Id: I6d7cc8472af8221a4cc05e759cc1bc6c62ce0e7c
    Closes-Bug: #1825291


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1825291

Title:
  TypeError: unhashable type: 'dict' in neutron-vpnaas while deleting
  routers

Status in neutron:
  Fix Released

Bug description:
  OpenStack version: stein (8.0.0, kolla build 20190417)

  While deleting routers as part of the tempest run, the following exception has been logged:
  ```
  Error while deleting router ba955d36-2ac4-47b8-aae2-3bf4a2fd2f79: TypeError: unhashable type: 'dict'
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent Traceback (most recent call last):
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent   File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/neutron/agent/l3/agent.py", line 463, in _safe_router_removed
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent     self.l3_ext_manager.delete_router(self.context, ri.router)
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent   File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/neutron/agent/l3/l3_agent_extensions_manager.py", line 66, in delete_router
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent     extension.obj.delete_router(context, data)
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent   File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/neutron_vpnaas/services/vpn/agent.py", line 80, in delete_router
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent     device_driver.destroy_router(data)
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent   File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/neutron_vpnaas/services/vpn/device_drivers/ipsec.py", line 1005, in destroy_router
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent     self.destroy_process(process_id)
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent   File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/neutron_vpnaas/services/vpn/device_drivers/ipsec.py", line 991, in destroy_process
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent     if process_id in self.processes:
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent TypeError: unhashable type: 'dict'
  2019-04-17 21:25:33.512 36 ERROR neutron.agent.l3.agent
  ```

  Looking at methods in the traceback, call to
  `extension.obj.delete_router` has been updated in commit
  4bb78e8c215d24cd2fc9168e7bfbb47ceb89de3e to pass a RouterInfo object
  instead of the router_id, but neutron-vpnaas has never been updated
  accordingly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1825291/+subscriptions