yahoo-eng-team team mailing list archive

[OpenStack Infra <1822262@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/648676
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a9324ad84c6ef9b645643e8087f0f200d0ab1e88
Submitter: Zuul
Branch:    master

commit a9324ad84c6ef9b645643e8087f0f200d0ab1e88
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>
Date:   Fri Mar 29 13:46:32 2019 +0100

    Only call _fill_provider_mapping if claim succeeds
    
    During re-schedule condutor takes the next Selecton object from the
    host list and tries to allocate the requested resources on the host in
    the Selection object. So far the conductor also tried to find the
    resource provide mapping for such allocation even if the resource claim
    is failed. This is unnecessary. This patch makes sure that mapping is
    tried to be calculated if the claim succeeds first.
    
    Change-Id: I9944398c38d11466d27c2a4b24035b26d264b000
    Closes-Bug: #1822262


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1822262

Title:
  Unnecessary _fill_provider_mapping call during reschedule when claim
  fails

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  During re-schedule the RequestGroup - RP mapping needs to be
  recalculated based on the new host selected. The current
  implementation unconditionally try to calculate the mapping even if
  the resource claim on the new host was unsuccessful [1]. This is
  wasteful.

  The mapping can be done conditionally after the claim was successful.

  [1]https://github.com/openstack/nova/blob/34a8e8ccf61865504b1a50c1d43a25a57d954119/nova/conductor/manager.py#L670-L680

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1822262/+subscriptions