yahoo-eng-team team mailing list archive

[OpenStack Infra <1825787@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/654394
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8f2fc1ee5ee0d5cf8f412fa510adb87f3ed5f4b2
Submitter: Zuul
Branch:    master

commit 8f2fc1ee5ee0d5cf8f412fa510adb87f3ed5f4b2
Author: LIU Yulong <i@xxxxxxxxxxxx>
Date:   Thu Apr 18 15:47:38 2019 +0800

    List ha router count should not include dvr local router
    
    Due to the class inheriting order the dvr local router will
    be counted to the l3 agent restart query. This will cause
    l3 agent run the ha port down action. This patch renames
    the function to avoid that.
    
    Closes-Bug: #1825787
    Change-Id: Id965a6140ae9a06e0b6707800933cbc14bf5bf3f


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1825787

Title:
  [L3][HA] agent HA router count should not include dvr local router

Status in neutron:
  Fix Released

Bug description:
  If dvr local router was processed in one l3 agent because it is
  required by other functionality. For instance, DHCP agent for one
  network will trigger L3 agent hosting the dvr_local router to it. If
  the agent mode is `dvr_snat`, this dvr router will be counted to the
  HA router list. This is not correct for l3 agent  [1] during the
  restart. Then the HA router related process count can not match the HA
  router list. The HA port `DOWN` action will be triggered
  unnecessarily. The issue is because function _get_router_ids_for_agent
  [2] is overrided by [3] in for dvr. Such dvr local router will be
  counted to the router ids list.

  [1] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L246
  [2] https://github.com/openstack/neutron/blob/master/neutron/db/l3_agentschedulers_db.py#L323
  [3] https://github.com/openstack/neutron/blob/master/neutron/db/l3_dvrscheduler_db.py#L401

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1825787/+subscriptions