← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1822105] Re: Policy rules related to "sub parameters" doesn't work properly

 

Reviewed:  https://review.opendev.org/648532
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9318fb8bb930a65cb0b388fd4a40fc83183d9199
Submitter: Zuul
Branch:    master

commit 9318fb8bb930a65cb0b388fd4a40fc83183d9199
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Thu Mar 28 21:36:11 2019 +0100

    Fix creating policy rules from subattributes.
    
    In case of policy rule checks for rules like e.g.
    "create_port:fixed_ips:subnet" couldn't be created to be
    passed to policy enforcer because policy module could only
    create rule checks for subattributes which are dict types.
    
    With this patch checks for such rules can be created also for
    attributes which are list of dicts, like e.g. fixed_ips in port
    resource.
    
    Change-Id: I02fffe77f57a513d2362df78885d327042bb8095
    Closes-Bug: #1822105


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1822105

Title:
  Policy rules related to "sub parameters" doesn't work properly

Status in neutron:
  Fix Released

Bug description:
  We have for example rules like:

  "create_port:fixed_ips:subnet_id" in neutron's policy,

  Ufortunatelly in https://github.com/openstack/neutron/blob/97376032b4c19ac6a479b524ec6a04460b79868b/neutron/policy.py#L192 check rule will always only have match like create_port:fixed_ip and will not include anything else.
  So later it will not match this rule in enforcer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1822105/+subscriptions


References