yahoo-eng-team team mailing list archive

[OpenStack Infra <1823038@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/657849
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=aacd11ab9f8f24291f369d23662b0cb6b3fe43e3
Submitter: Zuul
Branch:    master

commit aacd11ab9f8f24291f369d23662b0cb6b3fe43e3
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Fri May 10 10:58:08 2019 +0000

    Remove rootwrap configuration from neutron-keepalived-state-change
    
    New IP command introduced by Ie3fe825d65408fc969c478767b411fe0156e9fbc
    requires only privsep initialization. This patch removes the prisep
    error FailedToDropPrivileges when executed under neutron-rootwrap.
    
    Closes-Bug: #1823038
    
    Change-Id: I6cde3c9dae7ffdccce49e88c3c79d1c379f291cf


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1823038

Title:
  Neutron-keepalived-state-change fails to check initial router state

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive pike series:
  Fix Released
Status in Ubuntu Cloud Archive queens series:
  Fix Released
Status in Ubuntu Cloud Archive rocky series:
  Fix Released
Status in Ubuntu Cloud Archive stein series:
  Fix Released
Status in neutron:
  Fix Released
Status in neutron package in Ubuntu:
  Fix Released
Status in neutron source package in Bionic:
  Fix Released
Status in neutron source package in Cosmic:
  Fix Released
Status in neutron source package in Disco:
  Fix Released

Bug description:
  [Impact]
  Fix for bug 1818614 in *-proposed includes a regression is the deployment is not using the rootwrap-daemon.

  [Test Case]
  See bug 1818614

  [Regression Potential]
  Low - this is a minor fix to resolve a regression due to the SRU bug 1818614.

  [Original Description]

  As fix for bug https://bugs.launchpad.net/neutron/+bug/1818614 we
  added to neutron-keepalived-state-change monitor possibility to check
  initial status of router (master or slave).

  Unfortunately for some reason I see now in journal log of functional
  job that this check is failing with error like:

  Apr 03 09:19:09 ubuntu-bionic-ovh-gra1-0004666718 neutron-keepalived-state-change[1553]: 2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change [-] Failed to get initial status of router cd300e6b-8222-4100-8f6a-3b5c4d5fe37b: FailedToDropPrivileges: privsep helper command exited non-zero (96)
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change Traceback (most recent call last):
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change   File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/agent/l3/keepalived_state_change.py", line 98, in handle_initial_state
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change     for address in ip.addr.list():
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change   File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/agent/linux/ip_lib.py", line 540, in list
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change     **kwargs)
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change   File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/agent/linux/ip_lib.py", line 1412, in get_devices_with_ip
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change     devices = privileged.get_link_devices(namespace, **link_args)
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change   File "/home/zuul/src/git.openstack.org/openstack/neutron/.tox/dsvm-functional-python27/local/lib/python2.7/site-packages/oslo_privsep/priv_context.py", line 240, in _wrap
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change     self.start()
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change   File "/home/zuul/src/git.openstack.org/openstack/neutron/.tox/dsvm-functional-python27/local/lib/python2.7/site-packages/oslo_privsep/priv_context.py", line 251, in start
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change     channel = daemon.RootwrapClientChannel(context=self)
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change   File "/home/zuul/src/git.openstack.org/openstack/neutron/.tox/dsvm-functional-python27/local/lib/python2.7/site-packages/oslo_privsep/daemon.py", line 328, in __init__
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change     raise FailedToDropPrivileges(msg)
                                                                                           2019-04-03 09:19:09.778 1553 ERROR neutron.agent.l3.keepalived_state_change FailedToDropPrivileges: privsep helper command exited non-zero (96)

  Example of such error: http://logs.openstack.org/25/645225/8/check
  /neutron-functional-
  python27/0704654/controller/logs/journal_log.txt.gz#_Apr_03_09_19_09

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1823038/+subscriptions