← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1829889] Re: _assert_ipv6_accept_ra method should wait until proper settings will be configured

 

Reviewed:  https://review.opendev.org/660690
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=62b2f2b1b1e2d8c0c2ffc1fd2ae9467eb2c1ef07
Submitter: Zuul
Branch:    master

commit 62b2f2b1b1e2d8c0c2ffc1fd2ae9467eb2c1ef07
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Wed May 22 13:49:55 2019 +0200

    Wait to ipv6 accept_ra be really changed by L3 agent
    
    In functional tests for L3 HA agent, like e.g.
    L3HATestFailover.test_ha_router_failover
    it may happen that L3 agent will not change ipv6 accept_ra
    knob and test fails because it checks that only once just
    after router state is change.
    
    This patch fixes that race by adding wait for 60 seconds to
    ipv6 accept_ra change.
    
    Change-Id: I459ce4b791c27b1e3d977e0de9fbdb21a8a379f5
    Closes-Bug: #1829889


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1829889

Title:
  _assert_ipv6_accept_ra method should wait until proper settings will
  be configured

Status in neutron:
  Fix Released

Bug description:
  This method is defined in
  neutron/tests/functional/agent/l3/framework.py and it should use
  wait_until_true to avoid potential race conditions between test
  assertions and what L3 agent is doing.

  It seems that e.g. in http://logs.openstack.org/61/659861/1/check
  /neutron-functional/3708673/testr_results.html.gz there was such race
  which caused test failure.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1829889/+subscriptions


References