yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1793029] Re: adding 0.0.0.0/0 address pair to a port bypasses all other vm security groups

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: OpenStack Infra <1793029@xxxxxxxxxxxxxxxxxx>
Date: Wed, 29 May 2019 16:32:37 -0000
Reply-to: Bug 1793029 <1793029@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

Reviewed:  https://review.opendev.org/661594
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=e02c4b214b6762823c5e1ae5719f08f5f51910e8
Submitter: Zuul
Branch:    master

commit e02c4b214b6762823c5e1ae5719f08f5f51910e8
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Mon May 27 02:45:15 2019 +0200

    [api-ref] Add short warning about ANY IP address in allowed address pair
    
    Change-Id: Ie3ed5ea81e0df50a699174fef95eb32337ed5682
    Closes-Bug: #1793029


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1793029

Title:
  adding 0.0.0.0/0 address pair to a port  bypasses all other vm
  security groups

Status in neutron:
  Fix Released
Status in OpenStack Security Advisory:
  Won't Fix
Status in OpenStack Security Notes:
  New

Bug description:
  On an openstack-ansible / newton setup with linuxbridge, a customer
  ran:

  neutron port-update $port-uuid --allowed-address-pairs type=dict
  list=true ip_address=0.0.0.0/0

  to bypass the ip source restriction (pfsense router and had to route
  packets).

  The impact of running the above, was an allow all rule was added to
  all ports in the network, bypassing all security groups.

  The iptables rule:

   905K   55M RETURN     all  --  *      *       0.0.0.0/0
  0.0.0.0/0            match-set NIPv44046d62c-59c8-4fd0-a547- src

  used on all ports, now triggers as:

  0.0.0.0/1
  128.0.0.0/1

  was added to the ipset NIPv44046d62c-59c8-4fd0-a547 (verified by
  looking at the ipset on the nova hosts). Removing the two lines from
  the ipset restored all security groups.

  Expected result was to remove ip filtering on the single port.

  This sounds similar to:

  https://bugs.launchpad.net/neutron/+bug/1461054

  but is marked fixed long ago.

  I've marked this as a security bug as a change to a single port can
  bypass other ports security groups.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1793029/+subscriptions