yahoo-eng-team team mailing list archive

[OpenStack Infra <1825943@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/661760
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=93015527f02cb54b0b2bc07c8c9c239c63878264
Submitter: Zuul
Branch:    master

commit 93015527f02cb54b0b2bc07c8c9c239c63878264
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Mon May 27 13:17:28 2019 +0200

    Add kill hooks for external processes
    
    This patch adds possibility to configure kill hooks used to kill
    external processes, like dnsmasq or keepalived.
    
    Change-Id: I29dfbedfb7167982323dcff1c4554ee780cc48db
    Closes-Bug: #1825943


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1825943

Title:
  [RFE] Implement "stop agent" hook script support in Neutron

Status in neutron:
  Fix Released

Bug description:
  Dear all,

  Following a quick thread on the openstack-discuss ML[1], I would like to request a new feature:
  Hook script support for Neutron agents.

  The Why:
  Neutron doesn't know about containers, and just kills processes whenever it doesn't need them, keeping dangling containers.
  This can lead to some issues, among them:
  - disk space usage
  - "failed" containers (exit-code 137 instead of a clean 0)
  - issues when validating container state in CI[2]
  - possible issue starting a new container due to name already used (not yet seen, but might occur)

  The What:
  Currently, launching an agent already supports a so-called "wrapper" (script). The current use in TripleO is to start a new container with the right options.
  Adding such a feature for the "stop" part would allow to do more than just kill the process:
  - clean up the configuration (in bare-metal use)
  - clean up temporary files (in bare-metal use)
  - clean up the container(s) instead of keeping them in failed state

  The How:
  Apparently, it might be possible to take advantage of the "get_stop_command" parameter for the "external_process.ProcessMonitor"[3].

  Thank you!

  Cheers,

  C.

  
  [1] http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005258.html
  [2] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/validate-services/tasks/containers.yaml#L18-L36
  [3] https://github.com/openstack/neutron/blob/master/neutron/agent/linux/external_process.py#L98

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1825943/+subscriptions