← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1779845] Re: hide_hypervisor_id doesn't hide hyperv signature for Windows VMs

 

Reviewed:  https://review.opendev.org/579897
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ca543438e183b2bd97a08ef781ddeab8303354ed
Submitter: Zuul
Branch:    master

commit ca543438e183b2bd97a08ef781ddeab8303354ed
Author: Konstantinos Samaras-Tsakiris <konstantinos.samaras-tsakiris@xxxxxxx>
Date:   Tue Jul 3 12:28:55 2018 +0000

    Hide hypervisor id on windows guests
    
    Blueprints hide-hypervisor-id-flavor-extra-spec [1] and
    add-kvm-hidden-feature [2] allow hiding KVM's signature for guests,
    which is necessary for Nvidia drivers to work in VMs with passthrough
    GPUs.  While this works well for linux guests on KVM, it doesn't work
    for Windows guests.
    
    For them, KVM emulates some HyperV features. With the
    current implementation, KVM's signature is hidden, but HyperV's is not,
    and Nvidia drivers don't work in Windows VMs.
    
    This change generates an extra element in the libvirt xml for Windows
    guests on KVM which obfuscates HyperV's signature too, controlled by the
    existing image and flavor parameters (img_hide_hypervisor_id and
    hide_hypervisor_id correspondingly). The extra xml element is
      <vendor_id state='on' value='1234567890ab'/>
    in features/hyperv.
    
    [1] https://blueprints.launchpad.net/nova/+spec/hide-hypervisor-id-flavor-extra-spec
    [2] https://blueprints.launchpad.net/nova/+spec/add-kvm-hidden-feature
    
    Change-Id: Iaaeae9281301f14f4ae9b43f4a06de58b699fd68
    Closes-Bug: 1779845


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1779845

Title:
  hide_hypervisor_id doesn't hide hyperv signature for Windows VMs

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Blueprints hide-hypervisor-id-flavor-extra-spec and add-kvm-hidden-feature allow hiding KVM's signature for guests, which is necessary for Nvidia drivers to work in VMs with passthrough GPUs.
  While this works well for linux guests on KVM hypervisors, it doesn't work for Windows guests on KVM. For them, KVM emulates some HyperV features. With the current implementation, KVM's signature is hidden, but HyperV's is not, and Nvidia drivers don't work in Windows VMs.

  I propose generating an extra tag in the libvirt xml for Windows
  guests on KVM which obfuscates HyperV's signature too, controlled by
  the existing image and flavor parameters (img_hide_hypervisor_id and
  hide_hypervisor_id correspondingly).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1779845/+subscriptions


References