yahoo-eng-team team mailing list archive

[OpenStack Infra <1831963@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/663840
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=0182868be5a3d07755a5039d77ff53ff3d770147
Submitter: Zuul
Branch:    master

commit 0182868be5a3d07755a5039d77ff53ff3d770147
Author: Abhishek Kekane <akekane@xxxxxxxxxx>
Date:   Fri Jun 7 06:24:36 2019 +0000

    Unit tests fails with new glance_store version 0.29.0
    
    Around 11 unit tests are failing [1] with a recent patch [2] merged in
    glance_store. The reason behind the failure is glance unit tests are
    loading rbd store which is not supported in gate. Earlier these tests
    were passing because they were not trying to connect to rados while
    loading the store, but after merging of recent patch [1] it tries to
    connect to rados via configure_add method of rbd driver.
    
    To avoid these kind of failures in near future we should drop using
    rbd store in tests as we know it is not supported in gate.
    
    NOTE:
    Also corrected the naming conventions of store identifiers, instead
    of using file1 etc., used appropriate names.
    
    [1] http://logs.openstack.org/40/663740/1/check/cross-glance-py27/50a9a9c/
    [2] https://review.opendev.org/660340
    
    Change-Id: I18add352238e93c5d4ade8b3e8d967b2f639cdad
    Closes-Bug: #1831963


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1831963

Title:
  unit tests fails with new glance_store version 0.29.0

Status in Glance:
  Fix Released

Bug description:
  Around 11 unit tests are failing [1] after recent patch [2] to set
  _url_prefix to store instance is merged. The reason for failure is
  unit tests tries to create rbd store [3] which is now tries to connect
  to Rados. As we all know that the zuul jobs does not support ceph/rbd
  it does not install dependent modules of rbd/ceph, which causes the
  failure.

  
  File "/home/zuul/src/opendev.org/openstack/glance/.tox/py27/local/lib/python2.7/site-packages/glance_store/_drivers/rbd.py", line 270, in get_connection
      client = rados.Rados(conffile=conffile, rados_id=rados_id)
  AttributeError: 'NoneType' object has no attribute 'Rados'

  To avoid these kind of failures, need to drop rbd store from loading
  as it is not supported in gate.

  
  [1] http://logs.openstack.org/40/663740/1/check/cross-glance-py27/50a9a9c/testr_results.html.gz
  [2] https://review.opendev.org/660340
  [3] https://github.com/openstack/glance/blob/master/glance/tests/unit/base.py#L75

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1831963/+subscriptions