yahoo-eng-team team mailing list archive

[OpenStack Infra <1832210@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/664234
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=5c334d584b180c735d8744ff1807f2747c024a55
Submitter: Zuul
Branch:    master

commit 5c334d584b180c735d8744ff1807f2747c024a55
Author: James Page <james.page@xxxxxxxxxx>
Date:   Mon Jun 10 10:36:05 2019 +0100

    netfilter_log: Correctly decode binary type prefix
    
    Under Python 3, firewall log prefixes are incorrectly decoded
    resulting in a mismatch between the stringy-fied 'prefix' value
    and the information available in the prefixes data.
    
    Use oslo.utils safe_decode function to ensure that data is
    correctly decoded.
    
    Change-Id: I9742207e98c07f0a4632631631288d9ada8cf8c7
    Closes-Bug: 1832210


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1832210

Title:
  incorrect decode of log prefix under python 3

Status in neutron:
  Fix Released
Status in neutron-fwaas package in Ubuntu:
  New
Status in neutron-fwaas source package in Cosmic:
  New
Status in neutron-fwaas source package in Disco:
  New
Status in neutron-fwaas source package in Eoan:
  New

Bug description:
  Under Python 3, the prefix of a firewall log message is not correctly
  decoded "b'10612530182266949194'":

  2019-06-10 09:14:34 Unknown cookie packet_in pkt=ethernet(dst='fa:16:3e:c6:58:5e',ethertype=2048,src='fa:16:3e:e0:2c:be')ipv4(csum=51290,dst='10.5.0.10',flags=2,header_length=5,identification=37612,offset=0,option=None,proto=6,src='192.168.21.182',tos=16,total_length=52,ttl=63,version=4)tcp(ack=3151291228,bits=17,csum=23092,dst_port=57776,offset=8,option=[TCPOptionNoOperation(kind=1,length=1), TCPOptionNoOperation(kind=1,length=1), TCPOptionTimestamps(kind=8,length=10,ts_ecr=1574746440,ts_val=482688)],seq=2769917228,src_port=22,urgent=0,window_size=3120)
  2019-06-10 09:14:34 {'prefix': "b'10612530182266949194'", 'msg': "ethernet(dst='fa:16:3e:c6:58:5e',ethertype=2048,src='fa:16:3e:e0:2c:be')ipv4(csum=51290,dst='10.5.0.10',flags=2,header_length=5,identification=37612,offset=0,option=None,proto=6,src='192.168.21.182',tos=16,total_length=52,ttl=63,version=4)tcp(ack=3151291228,bits=17,csum=23092,dst_port=57776,offset=8,option=[TCPOptionNoOperation(kind=1,length=1), TCPOptionNoOperation(kind=1,length=1), TCPOptionTimestamps(kind=8,length=10,ts_ecr=1574746440,ts_val=482688)],seq=2769917228,src_port=22,urgent=0,window_size=3120)"}
  2019-06-10 09:14:34 {'0bf81ded-bf94-437d-ad49-063bba9be9bb': [<neutron_fwaas.services.logapi.agents.drivers.iptables.log.LogPrefix object at 0x7f7563079048>, <neutron_fwaas.services.logapi.agents.drivers.iptables.log.LogPrefix object at 0x7f756308abe0>]}

  This results in the firewall log driver not being able to map the
  message to the associated port and log resources in neutron resulting
  in the 'unknown cookie packet_in' warning message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1832210/+subscriptions