← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1833182] Re: Wrong assert methods in unit tests for libvirt driver

 

Reviewed:  https://review.opendev.org/665897
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c40de761259c88904fa509b0c9d713a9827bd292
Submitter: Zuul
Branch:    master

commit c40de761259c88904fa509b0c9d713a9827bd292
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Tue Jun 18 16:39:58 2019 +0900

    Fix wrong assert methods
    
    Fix wrong assert methods in the unit tests for libvirt driver.
    
    Change-Id: I804d504d21953a936a18b76334557fe3ccb97107
    Closes-Bug: #1833182


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1833182

Title:
  Wrong assert methods in unit tests for libvirt driver

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  'asset_called' should be 'assert_called'.
  'asset_called_once' should be 'assert_called_once'.

  https://opendev.org/openstack/nova/src/commit/a628d2f09a42a0faa5fcb36793e2304de634638e/nova/tests/unit/virt/libvirt/test_driver.py#L10107
  https://opendev.org/openstack/nova/src/commit/a628d2f09a42a0faa5fcb36793e2304de634638e/nova/tests/unit/virt/libvirt/test_driver.py#L10126

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1833182/+subscriptions


References