yahoo-eng-team team mailing list archive

[OpenStack Infra <1821244@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/645352
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9fa03d4d72609b6eb2ace7b89eaf437f94252be0
Submitter: Zuul
Branch:    master

commit 9fa03d4d72609b6eb2ace7b89eaf437f94252be0
Author: Mohammed Naser <mnaser@xxxxxxxxxxxx>
Date:   Thu Mar 21 17:05:24 2019 -0400

    bdm: store empty object as connection_info by default
    
    There are several code paths which expect connection_info to be
    a valid JSON object.  However, if we don't find a value, we are
    setting it to an initial value of 'None' which evenutally gets
    converted to 'null' as JSON and stored in the database.
    
    This patch sets the default value to {} so that any new block
    device mappings have an empty object, rather than NULL.
    
    Closes-Bug: #1821244
    Change-Id: I15a7c13edf78884ec223fd531a78a341106b41b8


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1821244

Title:
  Failed volume creation can result in invalid `connection_info` field

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  If a volume fails to create, this can result in `connection_info`
  having the literal value of 'null' which breaks things down the road
  that expect it to be a dictionary, an example of a breakage:

  https://github.com/openstack/nova/blob/a5e3054e1d6df248fc4c00b9abd7289dde160393/nova/compute/utils.py#L1260

  This would fail with:

  AttributeError: 'NoneType' object has no attribute 'get'

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1821244/+subscriptions