yahoo-eng-team team mailing list archive

[Balazs Gibizer <balazs.gibizer@xxxxxxxx>]

Public bug reported:

The notification sample test for unshelve waits for the instance to
reach ACTIVE state and then asserts if unshelve.end notification is
emitted properly. However the instance.vm_state is set to ACTIVE
earlier[1] than emitting the unshelve.end notification[2]. This can
cause two different test case failures.

1) _test_unshelve_server() fails with no ushelve.end notification
received.

2) _test_shelve_and_shelve_offload_server() also has a unshelve action
at the end and that test step also only waits for the the ACTIVE state.
So the unshelve.end notification from the end of
_test_shelve_and_shelve_offload_server() can bleed into the
_test_unshelve_server() step causing that it receive one more
notifications.


[1] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5322-L5326
[2] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5329
[3] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/tests/functional/notification_sample_tests/test_instance.py#L836

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1835070

Title:
  The unshelve notification functional sample test fails intermittently

Status in OpenStack Compute (nova):
  New

Bug description:
  The notification sample test for unshelve waits for the instance to
  reach ACTIVE state and then asserts if unshelve.end notification is
  emitted properly. However the instance.vm_state is set to ACTIVE
  earlier[1] than emitting the unshelve.end notification[2]. This can
  cause two different test case failures.

  1) _test_unshelve_server() fails with no ushelve.end notification
  received.

  2) _test_shelve_and_shelve_offload_server() also has a unshelve action
  at the end and that test step also only waits for the the ACTIVE
  state. So the unshelve.end notification from the end of
  _test_shelve_and_shelve_offload_server() can bleed into the
  _test_unshelve_server() step causing that it receive one more
  notifications.

  
  [1] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5322-L5326
  [2] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5329
  [3] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/tests/functional/notification_sample_tests/test_instance.py#L836

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1835070/+subscriptions