yahoo-eng-team team mailing list archive

[Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>]

Public bug reported:

In nova/tests/unit/compute/test_compute.py, the following method does
not check anything.

    def test_pre_live_migration_instance_has_no_fixed_ip(self):
        # Confirm that no exception is raised if there is no fixed ip on
        # pre_live_migration
        self.compute.driver.pre_live_migration(
            test.MatchType(nova.context.RequestContext),
            test.MatchType(objects.Instance),
            {'block_device_mapping': []},
            mock.ANY, mock.ANY, mock.ANY)

The method was mentioned in https://review.opendev.org/#/c/330297/ .
It was necessary to follow it up.
The follow-up patch was https://review.opendev.org/#/c/340713/, but it has not been merged.

** Affects: nova
     Importance: Undecided
     Assignee: Takashi NATSUME (natsume-takashi)
         Status: New


** Tags: testing

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1836692

Title:
  Useless unit test for pre_live_migration method in compute manager

Status in OpenStack Compute (nova):
  New

Bug description:
  In nova/tests/unit/compute/test_compute.py, the following method does
  not check anything.

      def test_pre_live_migration_instance_has_no_fixed_ip(self):
          # Confirm that no exception is raised if there is no fixed ip on
          # pre_live_migration
          self.compute.driver.pre_live_migration(
              test.MatchType(nova.context.RequestContext),
              test.MatchType(objects.Instance),
              {'block_device_mapping': []},
              mock.ANY, mock.ANY, mock.ANY)

  The method was mentioned in https://review.opendev.org/#/c/330297/ .
  It was necessary to follow it up.
  The follow-up patch was https://review.opendev.org/#/c/340713/, but it has not been merged.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1836692/+subscriptions