yahoo-eng-team team mailing list archive

[OpenStack Infra <1836037@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/670105
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=12ab7c4cb149147e3e7886233f4ba99c3484f923
Submitter: Zuul
Branch:    master

commit 12ab7c4cb149147e3e7886233f4ba99c3484f923
Author: elajkat <lajos.katona@xxxxxxxx>
Date:   Wed Jul 10 17:20:22 2019 +0200

    segments: fix rp inventory update
    
    The patch https://review.opendev.org/663980 made resource provider
    inventory update failing with the assumption that inventory update
    expects a dict with a key of the resource class, like resource provider
    inventories update.
    See the placement API-ref:
    https://developer.openstack.org/api-ref/placement/#update-resource-provider-inventory
    https://developer.openstack.org/api-ref/placement/#update-resource-provider-inventories
    
    Change-Id: I7de1a947b864eb5ac57ebaca895f827d2e667443
    Closes-Bug: #1836037
    Related-Bug: #1828543


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1836037

Title:
  Routed provider networks nova inventory update fails

Status in neutron:
  Fix Released

Bug description:
  The patch https://review.opendev.org/663980 introduced a serious misreading of placement API.
  The lines https://review.opendev.org/#/c/663980/2/neutron/services/segments/plugin.py@220 assumes that "Show resource provider inventory" (see: https://developer.openstack.org/api-ref/placement/?expanded=show-resource-provider-inventory-detail#show-resource-provider-inventory) returns a dict with like 
  {'IPV4_ADDRESS': {'allocation_ratio': 42....}}
  but if we read the documentation the truth is that the response is a dict like:
  {'allocation_ratio': 42....}

  The other fix in that patch is good as it is
  (https://review.opendev.org/#/c/663980/2/neutron/services/segments/plugin.py@255)
  for "Update resource provider inventories" (see:
  https://developer.openstack.org/api-ref/placement/?expanded=update-
  resource-provider-inventories-detail#update-resource-provider-
  inventories)

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1836037/+subscriptions