← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1836671] Re: string_concat is removed from django as of 2.1

 

Reviewed:  https://review.opendev.org/671045
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6f4742457fae755e465315f17f39c3977c833d0e
Submitter: Zuul
Branch:    master

commit 6f4742457fae755e465315f17f39c3977c833d0e
Author: Corey Bryant <corey.bryant@xxxxxxxxxxxxx>
Date:   Tue Jul 16 09:56:48 2019 -0400

    Switch from django string_concat to format_lazy
    
    string_concat was removed in django 2.1 when it reached the end
    of it's deprecation cycle. It was removed because the same behavior
    can be achieved with format_lazy.
    
    For more details see:
    https://docs.djangoproject.com/en/2.2/releases/2.1/
    
    Change-Id: I5e1c9bdfa1d0e049e0516198abbdb76be1667216
    Closes-Bug: #1836671
    Partial-Bug: #1789046


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1836671

Title:
  string_concat is removed from django as of 2.1

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  Fix Released

Bug description:
  I just tripped over this in Ubuntu development of Eoan (Train) where
  we are moving from python-django 1.11.22 to python-django 2.2.3.

  The traceback ends with:

  File "/usr/lib/python3/dist-packages/openstack_dashboard/dashboards/project/instances/tables.py", line 27, in <module>
    from django.utils.translation import string_concat
  ImportError: cannot import name 'string_concat' from 'django.utils.translation' (/usr/lib/python3/dist-packages/django/utils/translation/__init__.py)

  https://github.com/django/django/blob/master/docs/releases/2.1.txt
  states that "django.utils.translation.string_concat() is removed."

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1836671/+subscriptions


References