← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1839009] [NEW] os-server-external-events does not behave correctly for failed single events

 

Public bug reported:

The "os-server-external-events" API does not behave correctly when the
request body contains a list of one event and if that event ends up in a
non-200 state, i.e if the event ends up in either 400 or 404 or 422
states, the function executes all the way to L147
(https://github.com/openstack/nova/blob/433b1662e48db57aaa42e11756fa4a6d8722b386/nova/api/openstack/compute/server_external_events.py#L147)
and overall returns a 404 HTTP response without any body. This is wrong
since as per the documentation it should return the respective codes
(422/404/400) to the client.

Infact correctly speaking, if out of the list of provided events, if at
least one of them doesn't get into the "accepted_events" list, rest of
them are discarded without returning the correct response against each
event.

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: api

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1839009

Title:
  os-server-external-events does not behave correctly for failed single
  events

Status in OpenStack Compute (nova):
  New

Bug description:
  The "os-server-external-events" API does not behave correctly when the
  request body contains a list of one event and if that event ends up in
  a non-200 state, i.e if the event ends up in either 400 or 404 or 422
  states, the function executes all the way to L147
  (https://github.com/openstack/nova/blob/433b1662e48db57aaa42e11756fa4a6d8722b386/nova/api/openstack/compute/server_external_events.py#L147)
  and overall returns a 404 HTTP response without any body. This is
  wrong since as per the documentation it should return the respective
  codes (422/404/400) to the client.

  Infact correctly speaking, if out of the list of provided events, if
  at least one of them doesn't get into the "accepted_events" list, rest
  of them are discarded without returning the correct response against
  each event.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1839009/+subscriptions


Follow ups