← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1835724] Re: Legacy Images Dashboard's "Create Image" form fields are in random order in python 3 with HORIZON_IMAGES_UPLOAD_MODE = 'direct'

 

Reviewed:  https://review.opendev.org/670517
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9c30ca9c13f59267c1045d9faaca1eac1259fd41
Submitter: Zuul
Branch:    master

commit 9c30ca9c13f59267c1045d9faaca1eac1259fd41
Author: Yves-Gwenael Bourhis <yves-gwenael.bourhis@xxxxxxxxxx>
Date:   Fri Jul 12 14:37:44 2019 +0200

    Preserve form field order in python 3
    
    In python 3, the ExternalUploadMeta metaclass does not preserve the
    order of the fields of the class it is modifying.
    First we add a __prepare__() method which returns an empty
    collections.OrderedDict.
    That mapping records the methods and attributes of the class it is
    metaclassing as they are defined within the body of the class statement.
    Then we send a collections.OrderedDict to create the new class.
    
    Change-Id: I7223ae5bd931202c95602ec9674ae86b4708368d
    Closes-Bug: #1835724


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1835724

Title:
  Legacy Images Dashboard's "Create Image" form fields are in random
  order in python 3 with HORIZON_IMAGES_UPLOAD_MODE = 'direct'

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Some users still need the legacy images panel(
  `ANGULAR_FEATURES['images_panel'] = False` ) because of the category
  tabs.

  When using this panel, if the server runs in python 3 the field orders are at a fixed random order
  (see screenshot in attachment).
  What I mean by "fixed" random order is that the order changes when restarting the server (but the order stays the same after each refresh).

  This issue happens only with Python 3. The order is correct in Python
  2

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1835724/+subscriptions


References