yahoo-eng-team team mailing list archive

[OpenStack Infra <1544522@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/675041
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cf7d28eb6ea47818e9f3584f65ec025f5a46326b
Submitter: Zuul
Branch:    master

commit cf7d28eb6ea47818e9f3584f65ec025f5a46326b
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Wed Aug 7 14:38:45 2019 +0900

    Fix non-existent method of Mock
    
    There is no method called_once_with() in Mock object.
    Use assert_called_once_with() or assert_has_calls() instead.
    
    Change-Id: I9f73fcbe7c3dfd64e75ac8224c13934b03443cd5
    Closes-Bug: #1544522


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1544522

Title:
  Don't use Mock.called_once_with that does not exist

Status in Cinder:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in octavia:
  Fix Released
Status in python-designateclient:
  Fix Released
Status in python-openstackclient:
  Fix Released
Status in Rally:
  Fix Released
Status in Sahara:
  Fix Released
Status in OpenStack DBaaS (Trove):
  Fix Released

Bug description:
  class mock.Mock does not exist method "called_once_with", it just
  exists method "assert_called_once_with". Currently there are still
  some places where we use called_once_with method, we should correct
  it.

  NOTE: called_once_with() does nothing because it's a mock object.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions