← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1841090] [NEW] dhclient exit hook could be hiding non-zero return code

 

Public bug reported:

I'm seeing an empty dhcp lease file. Digging through the code we are
passing the -1 opt to dhclient in cloudinit.net.dhcp.dhcp_discovery.
This would allow a non-zero return code if dhclient has an issue.

I see though that there is an exit hook for dhclient:
https://git.launchpad.net/cloud-init/tree/tools/hook-dhclient. It seems
as though this hook could be hiding a non-zero return code from dhclient
main lease implementation (unless $reason is in one of those options
_and_ `cloud-init dhclient-hook` fails).

This does not seem like the desired behavior, as we get beyond the
dhclient call then only to fail on a zero-byte dhcp lease file.

** Affects: cloud-init
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1841090

Title:
  dhclient exit hook could be hiding non-zero return code

Status in cloud-init:
  New

Bug description:
  I'm seeing an empty dhcp lease file. Digging through the code we are
  passing the -1 opt to dhclient in cloudinit.net.dhcp.dhcp_discovery.
  This would allow a non-zero return code if dhclient has an issue.

  I see though that there is an exit hook for dhclient:
  https://git.launchpad.net/cloud-init/tree/tools/hook-dhclient. It
  seems as though this hook could be hiding a non-zero return code from
  dhclient main lease implementation (unless $reason is in one of those
  options _and_ `cloud-init dhclient-hook` fails).

  This does not seem like the desired behavior, as we get beyond the
  dhclient call then only to fail on a zero-byte dhcp lease file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1841090/+subscriptions


Follow ups