← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1719487] Re: nova-manage db archive_deleted_rows is not multi-cell aware

 

Reviewed:  https://review.opendev.org/507486
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=97b8cb3f5804cd39b7eb3ac2d481e43ceb52f2cf
Submitter: Zuul
Branch:    master

commit 97b8cb3f5804cd39b7eb3ac2d481e43ceb52f2cf
Author: Kevin_Zheng <zhengzhenyu@xxxxxxxxxx>
Date:   Tue Sep 26 19:02:00 2017 +0800

    nova-manage db archive_deleted_rows is not multi-cell aware
    
    The archive_deleted_rows cmd depend on DB connection config from config
    file, and when applying super-conductor mode, there are several config
    files for different cells. If so, the command can only archive rows in
    cell0 DB as it only reads the nova.conf
    
    This patch added code that provides --all-cells parameter to the
    command and read info for all cells from the api_db and then archive
    rows across all cells.
    
    The --all-cells parameter is passed on to the purge command when
    archive_deleted_rows is called with both --all-cells and --purge.
    
    Co-Authored-By: melanie witt <melwittt@xxxxxxxxx>
    
    Change-Id: Id16c3d91d9ce5db9ffd125b59fffbfedf4a6843d
    Closes-Bug: #1719487


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1719487

Title:
  nova-manage db archive_deleted_rows is not multi-cell aware

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  With the superconductor mode change in devstack in pike, the
  post_test_hook in the nova-next CI job is only cleaning up entries
  from the cell0 database:

  http://logs.openstack.org/58/506458/2/check/gate-tempest-dsvm-neutron-
  nova-next-full-ubuntu-xenial-nv/0d589b6/logs/devstack-gate-
  post_test_hook.txt.gz

  This is because there are 3 config files now:

  stack@devstack:~$ ls -l /etc/nova/
  total 40
  -rw-r--r-- 1 stack stack 3001 Sep 25 18:23 api-paste.ini
  -rw-r--r-- 1 stack stack  395 Sep 25 18:23 nova-api-uwsgi.ini
  -rw-r--r-- 1 stack stack  724 Sep 25 18:23 nova_cell1.conf
  -rw-r--r-- 1 stack stack 3495 Sep 25 18:54 nova.conf
  -rw-r--r-- 1 stack stack 3561 Sep 25 18:58 nova-cpu.conf
  -rw-r--r-- 1 root  root  2525 Sep 25 18:23 nova-dhcpbridge.conf
  -rw-r--r-- 1 stack stack  349 Sep 25 18:23 nova-metadata-uwsgi.ini
  -rw-r--r-- 1 stack stack  405 Sep 25 18:24 placement-uwsgi.ini
  -rw-r--r-- 1 root  root   941 Sep 25 18:23 rootwrap.conf
  drwxr-xr-x 2 root  root  4096 Sep 25 18:23 rootwrap.d

  nova.conf is configured for the API database and cell0 so it only
  removes entries from cell0.

  We could have nova-manage db archive_deleted_rows get the cells from
  the API database and iterate the cells to archive deleted rows.

  This might require a --fanout or --all-cells option to the command
  though so users would opt into the behavior.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1719487/+subscriptions


References